[minor] Added localization support to HalstackProvider and dateInput#2500
Open
Jialecl wants to merge 7 commits into
Open
[minor] Added localization support to HalstackProvider and dateInput#2500Jialecl wants to merge 7 commits into
Jialecl wants to merge 7 commits into
Conversation
Jialecl
changed the title
| const orderedWeekDays = useMemo(() => { | ||
| const weekDays = translatedLabels.calendar.daysShort; | ||
| return [...weekDays.slice(firstDayOfWeek - 1), ...weekDays.slice(0, firstDayOfWeek - 1)]; | ||
| }, [translatedLabels.calendar.daysShort]); |
Collaborator
There was a problem hiding this comment.
firstDayOfWeek should be included in the dependency array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.Purpose
LocaleTag has been added to the halstackprovider to aid in localization. For now only the date component works with it.